Remove space on regex for command "show isis adjacency vrf" #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BEFORE : p1 = re.compile(r'^IS-IS +[Pp]rocess: +(?P<process_id>\S+) +VRF: +(?P<vrf>\S+)$') AFTER : p1 = re.compile(r'^IS-IS +[Pp]rocess: +(?P<process_id>\S+) +VRF:+(?P<vrf>\S+)$') Remove the space after "VRF:" in the regex.
stevedhn
approved these changes
Aug 25, 2022
sjpatel21
approved these changes
Aug 30, 2022
|
Thanks for your contribution @fmabille09 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE : p1 = re.compile(r'^IS-IS +[Pp]rocess: +(?P<process_id>\S+) +VRF: +(?P\S+)$')
AFTER : p1 = re.compile(r'^IS-IS +[Pp]rocess: +(?P<process_id>\S+) +VRF:+(?P\S+)$')
Remove the space after "VRF:" in the regex.
Description
Support issue link - #693
Motivation and Context
On some n9k, when launching command: "show isis adjacency vrf all", the output put a whitespace or not after VRF. So the output can be
"IS-IS process: process_id VRF: default" or "IS-IS process: process_id VRF:default"
But actually the parser only support a white space.
p1 = re.compile(r'^IS-IS +[Pp]rocess: +(?P<process_id>\S+) +VRF: +(?P\S+)$')"
Impact (If any)
Change regex on parser to support whitespace or not
Screenshots:
Checklist: